Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for initial check status #1599

Merged
merged 2 commits into from
Aug 16, 2016

Conversation

hoffoo
Copy link
Contributor

@hoffoo hoffoo commented Aug 16, 2016

accidentally closed the pr, here is a proper commit for initial check status

old thread: #1573

case api.HealthWarning:
case api.HealthCritical:
default:
return fmt.Errorf(`invalid initial check state (%s), must be one of "%s", "%s", "%s", or "%s"`, sc.InitialStatus, api.HealthUnknown, api.HealthPassing, api.HealthWarning, api.HealthCritical)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid initial check state (%s), must be one of %q, %q, %q, %q or empty

@diptanu
Copy link
Contributor

diptanu commented Aug 16, 2016

@hoffoo Thanks! Left one small comment.

}

_, err = ParseFile(path)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also check that parsing the file resulted in the check that we are expecting by using reflect.DeepEquals

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay! it turns out it was actually broken without the mapstructure tag :x

@diptanu
Copy link
Contributor

diptanu commented Aug 16, 2016

@hoffoo Thanks! I am merging this one.

@diptanu diptanu merged commit 38689d0 into hashicorp:master Aug 16, 2016
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants